linux-kernel - Re: [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Nov 2018 16:49:19 -0600
From:   Rob Herring <robh@...nel.org>
To:     Tom Burkart <tom@...sec.com>
Cc:     Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio,
 capture-clear addition

On Wed, Nov 14, 2018 at 11:54:29PM +1100, Tom Burkart wrote:
> This patch changes the devicetree bindings for the pps-gpio driver
> from the integer based ABI to the descriptor based ABI.

? That has nothing to do with DT.

>  It also adds
> documentation for the device tree capture-clear option.  The legacy
> device tree entry for the GPIO pin is supported.
> 
> Signed-off-by: Tom Burkart <tom@...sec.com>
> ---
>  Documentation/devicetree/bindings/pps/pps-gpio.txt | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt b/Documentation/devicetree/bindings/pps/pps-gpio.txt
> index 3683874832ae..6c9fc0998d94 100644
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
> @@ -5,19 +5,23 @@ a GPIO pin.
>  
>  Required properties:
>  - compatible: should be "pps-gpio"
> -- gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
> +- pps-gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
> +Alternatively (DEPRECATED), instead of pps-gpios above, it may have:
> +- gpios: one PPS GPIO as above
>  
>  Optional properties:
>  - assert-falling-edge: when present, assert is indicated by a falling edge
>                         (instead of by a rising edge)
> +- capture-clear: when present, also capture the PPS clear event

Is this a h/w thing? or driver configuration?

>  
>  Example:
>  	pps {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_pps>;
>  
> -		gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> +		pps-gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
>  		assert-falling-edge;
> +		capture-clear;
>  
>  		compatible = "pps-gpio";
>  	};
> -- 
> 2.12.3
>