linux-kernel - Re: [PATCH v7 0/5] parisc: system call table generation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2g-7iR594Fs_goYCYPqgO6FRML5oi9vodDC_wKHF64bA@mail.gmail.com>
Date:   Fri, 16 Nov 2018 15:20:57 -0800
From:   Arnd Bergmann <arnd@...db.de>
To:     Helge Deller <deller@....de>
Cc:     Firoz Khan <firoz.khan@...aro.org>,
        Parisc List <linux-parisc@...r.kernel.org>,
        James.Bottomley@...senpartnership.com,
        John David Anglin <dave.anglin@...l.net>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        gregkh <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v7 0/5] parisc: system call table generation support

On Fri, Nov 16, 2018 at 1:55 PM Helge Deller <deller@....de> wrote:
> > On Fri, 16 Nov 2018 at 01:01, Helge Deller <deller@....de> wrote:
> > >
> > > On 14.11.2018 07:34, Firoz Khan wrote:
> > > > The purpose of this patch series is, we can easily
> > > > add/modify/delete system call table support by cha-
> > > > nging entry in syscall.tbl file instead of manually
> > > > changing many files. The other goal is to unify the
> > > > system call table generation support implementation
> > > > across all the architectures.
> > > >
> > > > The system call tables are in different format in
> > > > all architecture. It will be difficult to manually
> > > > add, modify or delete the system calls in the resp-
> > > > ective files manually. To make it easy by keeping a
> > > > script and which'll generate uapi header file and
> > > > syscall table file.
> > > >
> > > > syscall.tbl contains the list of available system
> > > > calls along with system call number and correspond-
> > > > ing entry point. Add a new system call in this arch-
> > > > itecture will be possible by adding new entry in the
> > > > syscall.tbl file.
> > > >
> > > > Adding a new table entry consisting of:
> > > >         - System call number.
> > > >         - ABI.
> > > >         - System call name.
> > > >         - Entry point name.
> > > >
> > > > ....
> > > > Firoz Khan (5):
> > > >   parisc: move __IGNORE* entries to non uapi header
> > > >   parisc: add __NR_syscalls along with __NR_Linux_syscalls
> > > >   parisc: add system call table generation support
> > > >   parisc: generate uapi header and system call table files
> > > >   parisc: syscalls: ignore nfsservctl for other architectures
> > >
> > > Firoz, you may add
> > > Acked-by: Helge Deller <deller@....de>
> > > to the whole parisc series.
> >
> > Sure, will do.
> > I'm on a vacation right now. will send mid next week.
>
> That's ok, there is no urgency.
>
> Actually, I noticed that the generated files unistd_32.h
> and unistd_64.h do have the same contents, since on parisc
> we keep the syscall numbers the same for 32- and 64-bit.
> With that in mind, we can simply generate on unistd.h
> file for both variants.

It depends on what we want to do in the future. When we add
around 20 new system calls fro y2038, my plan was to
only add them for 32-bit architectures, leaving holes on
64-bit ones. We can also assign the new numbers on parisc64
but they would have the same entry point as existing calls.

If you prefer doing it like that, your patch seems fine for that,
it's just slightly inconsistent with the other 64-bit architectures
then.

          Arnd