linux-kernel - Re: [PATCH] staging: gasket: formatting fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAW3YpZV_9orrAdkXCuZ_ciab-P14EfsCajdm1M7n3y45NCWQQ@mail.gmail.com>
Date:   Fri, 16 Nov 2018 18:46:10 -0800
From:   Todd Poynor <toddpoynor@...gle.com>
To:     robert.edward.deal@...il.com
Cc:     Rob Springer <rspringer@...gle.com>, benchan@...omium.org,
        Greg KH <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: gasket: formatting fixes

On Mon, Nov 12, 2018 at 1:27 PM Robert Deal
<robert.edward.deal@...il.com> wrote:
>
> Reformat arguments in a few functions in gasket_page_table.c to better
> follow linux kernel formatting standards.
>
> Signed-off-by: Robert Deal <robert.edward.deal@...il.com>
> ---
>  drivers/staging/gasket/gasket_page_table.c | 24 ++++++++++------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
> index f5253ba9a430..26755d9ca41d 100644
> --- a/drivers/staging/gasket/gasket_page_table.c
> +++ b/drivers/staging/gasket/gasket_page_table.c
> @@ -1088,9 +1088,9 @@ void gasket_page_table_reset(struct gasket_page_table *pg_tbl)
>  }
>
>  /* See gasket_page_table.h for description. */
> -int gasket_page_table_lookup_page(
> -       struct gasket_page_table *pg_tbl, ulong dev_addr, struct page **ppage,
> -       ulong *poffset)
> +int gasket_page_table_lookup_page(struct gasket_page_table *pg_tbl,
> +                                 ulong dev_addr, struct page **ppage,
> +                                 ulong *poffset)
>  {
>         uint page_num;
>         struct gasket_page_table_entry *pte;
> @@ -1134,9 +1134,9 @@ int gasket_page_table_lookup_page(
>  }
>
>  /* See gasket_page_table.h for description. */
> -bool gasket_page_table_are_addrs_bad(
> -       struct gasket_page_table *pg_tbl, ulong host_addr, ulong dev_addr,
> -       ulong bytes)
> +bool gasket_page_table_are_addrs_bad(struct gasket_page_table *pg_tbl,
> +                                    ulong host_addr, ulong dev_addr,
> +                                    ulong bytes)
>  {
>         if (host_addr & (PAGE_SIZE - 1)) {
>                 dev_err(pg_tbl->device,
> @@ -1150,8 +1150,8 @@ bool gasket_page_table_are_addrs_bad(
>  EXPORT_SYMBOL(gasket_page_table_are_addrs_bad);
>
>  /* See gasket_page_table.h for description. */
> -bool gasket_page_table_is_dev_addr_bad(
> -       struct gasket_page_table *pg_tbl, ulong dev_addr, ulong bytes)
> +bool gasket_page_table_is_dev_addr_bad(struct gasket_page_table *pg_tbl,
> +                                      ulong dev_addr, ulong bytes)
>  {
>         uint num_pages = bytes / PAGE_SIZE;
>
> @@ -1226,9 +1226,8 @@ int gasket_page_table_system_status(struct gasket_page_table *page_table)
>  }
>
>  /* Record the host_addr to coherent dma memory mapping. */
> -int gasket_set_user_virt(
> -       struct gasket_dev *gasket_dev, u64 size, dma_addr_t dma_address,
> -       ulong vma)
> +int gasket_set_user_virt(struct gasket_dev *gasket_dev, u64 size,
> +                        dma_addr_t dma_address, ulong vma)
>  {
>         int j;
>         struct gasket_page_table *pg_tbl;
> @@ -1346,8 +1345,7 @@ int gasket_free_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
>  }
>
>  /* Release all coherent memory. */
> -void gasket_free_coherent_memory_all(
> -       struct gasket_dev *gasket_dev, u64 index)
> +void gasket_free_coherent_memory_all(struct gasket_dev *gasket_dev, u64 index)
>  {
>         if (!gasket_dev->page_table[index])
>                 return;
> --
> 2.17.1
>

Acked-by: Todd Poynor <toddpoynor@...gle.com>

Thanks!