linux-kernel - Re: [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181117222405.14403260fhfcd07p@www.aussec.com>
Date:   Sat, 17 Nov 2018 22:24:05 +1100
From:   tom burkart <tom@...sec.com>
To:     Philipp Zabel <philipp.zabel@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear
 addition

Quoting Philipp Zabel <philipp.zabel@...il.com>:

> On Tue, Nov 13, 2018 at 5:08 AM Tom Burkart <tom@...sec.com> wrote:
>>
>> This patch changes the GPIO access for the pps-gpio driver from the
>> integer based API to the descriptor based API.  It also adds
>> documentation for the device tree capture-clear option and
>> device tree capture-clear extraction.
>>
>> The change from integer based GPIO API to the descriptor based API
>> breaks backward compatibility for the devicetree.  This is due to
>> the descriptor based API appending "-gpio" or "-gpios" (see
>> Documentation/gpio/base.txt.)
>
> Documentation/devicetree/bindings/gpio/gpio.txt says:
>  "While a non-existent <name> is considered valid
>   for compatibility reasons (resolving to the "gpios" property),
>   it is not allowed for new bindings."
>
> This is not a new binding, so there should be no reason to change it.
>
> gpiod_get() and friends support this by using the "gpios" property if
> they are passed a NULL con_id.
> of_find_gpio() in drivers/gpio/gpiolib-of.c contains the relevant code.

Hi Phillip,

Oops, sounds like I didn't read the documentation properly.  Thanks  
for the clarification.
A new patch will be on its way shortly...

Tom