linux-kernel - Re: [PATCH v2 2/2] ASoC: dt-bindings: add bindings for AK4118 transceiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181117155140.GA11554@bogus>
Date:   Sat, 17 Nov 2018 09:51:40 -0600
From:   Rob Herring <robh@...nel.org>
To:     Clément Péron <peron.clem@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: dt-bindings: add bindings for AK4118
 transceiver

On Wed, Nov 14, 2018 at 01:16:42PM +0100, Clément Péron wrote:
> Document the bindings for AK4118 S/PDIF transceiver
> 
> Signed-off-by: Clément Péron <peron.clem@...il.com>
> ---
>  .../devicetree/bindings/sound/ak4118.txt      | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/ak4118.txt b/Documentation/devicetree/bindings/sound/ak4118.txt
> new file mode 100644
> index 000000000000..6e11a2f7404c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak4118.txt
> @@ -0,0 +1,22 @@
> +AK4118 S/PDIF transceiver
> +
> +This device supports I2C mode.
> +
> +Required properties:
> +
> +- compatible : "asahi-kasei,ak4118"
> +- reg : The I2C address of the device for I2C
> +- reset-gpios: A GPIO specifier for the reset pin
> +- irq-gpios: A GPIO specifier for the IRQ pin

This should use 'interrupts' instead.

> +
> +Example:
> +
> +&i2c {
> +	ak4118: ak4118@13 {

spdif@13 ? Node names should be based on the class of device, but 
there's not really one defined for this.

> +		#sound-dai-cells = <0>;
> +		compatible = "asahi-kasei,ak4118";
> +		reg = <0x13>;
> +		reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>
> +		irq-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
> +	};
> +};
> -- 
> 2.19.1
>