linux-kernel - RE: [PATCH v8 09/13] arch/resctrl: Update the RESCTRL config parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM5PR12MB24715C9965DF98A97A8C9BC095DE0@DM5PR12MB2471.namprd12.prod.outlook.com>
Date:   Sat, 17 Nov 2018 16:30:56 +0000
From:   "Moger, Babu" <Babu.Moger@....com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "corbet@....net" <corbet@....net>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "reinette.chatre@...el.com" <reinette.chatre@...el.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC:     "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "qianyue.zj@...baba-inc.com" <qianyue.zj@...baba-inc.com>,
        "xiaochen.shen@...el.com" <xiaochen.shen@...el.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Singh, Brijesh" <brijesh.singh@....com>,
        "Hurwitz, Sherry" <sherry.hurwitz@....com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "luto@...nel.org" <luto@...nel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "rian@...m.mit.edu" <rian@...m.mit.edu>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: RE: [PATCH v8 09/13] arch/resctrl: Update the RESCTRL config
 parameter

Randy,

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org <linux-kernel-
> owner@...r.kernel.org> On Behalf Of Randy Dunlap
> Sent: Friday, November 16, 2018 3:18 PM
> To: Moger, Babu <Babu.Moger@....com>; tglx@...utronix.de;
> mingo@...hat.com; bp@...en8.de; corbet@....net;
> fenghua.yu@...el.com; reinette.chatre@...el.com; peterz@...radead.org;
> gregkh@...uxfoundation.org; davem@...emloft.net; akpm@...ux-
> foundation.org
> Cc: hpa@...or.com; x86@...nel.org; mchehab+samsung@...nel.org;
> arnd@...db.de; kstewart@...uxfoundation.org; pombredanne@...b.com;
> rafael@...nel.org; kirill.shutemov@...ux.intel.com; tony.luck@...el.com;
> qianyue.zj@...baba-inc.com; xiaochen.shen@...el.com;
> pbonzini@...hat.com; Singh, Brijesh <brijesh.singh@....com>; Hurwitz,
> Sherry <sherry.hurwitz@....com>; dwmw2@...radead.org; Lendacky,
> Thomas <Thomas.Lendacky@....com>; luto@...nel.org; joro@...tes.org;
> jannh@...gle.com; vkuznets@...hat.com; rian@...m.mit.edu;
> jpoimboe@...hat.com; linux-kernel@...r.kernel.org; linux-
> doc@...r.kernel.org
> Subject: Re: [PATCH v8 09/13] arch/resctrl: Update the RESCTRL config
> parameter
> 
> On 11/16/18 12:54 PM, Moger, Babu wrote:
> > CONFIG_RESCTRL will be used for both Intel and AMD to enable
> > Resource Control feature. Update the details and condition accordingly.
> >
> > Signed-off-by: Babu Moger <babu.moger@....com>
> > ---
> >  arch/x86/Kconfig | 19 ++++++++++++++-----
> >  1 file changed, 14 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 4aae7aba4d61..c5ef3afa89a6 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -448,13 +448,22 @@ config RETPOLINE
> >  config RESCTRL
> >  	bool "Resource Control feature support"
> >  	default n
> > -	depends on X86 && CPU_SUP_INTEL
> > +	depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
> >  	select KERNFS
> >  	help
> > -	  Select to enable resource allocation and monitoring which are
> > -	  sub-features of Intel Resource Director Technology(RDT). More
> > -	  information about RDT can be found in the Intel x86
> > -	  Architecture Software Developer Manual.
> > +	  Select to enable Resource Control feature support.
> > +
> > +	  These features are intended to provide the support for the
> allocation
> > +	  and monitoring the usage of certain system resources by one or
> more
> 
> 	  and monitoring of the usage
 
Sure. Will take care of this next revision.
> 
> > +	  processors.
> > +
> > +	  Intel refers this feature as Intel Resource Director Technology
> 
> 	        refers to this feature

Yes. Will take care.

> 
> > +	  (Intel(R) RDT). More information about RDT can be found in the
> > +	  Intel x86 Architecture Software Developer Manual.
> > +
> > +	  AMD refers this feature as AMD Platform Quality of Service(AMD
> QoS).
> 
> 	      refers to this feature

Sure. Will fix. Thanks for the comments.

> 
> > +	  More information about AMD QoS can be found in AMD64
> Technology
> > +	  Platform Quality of Service Extensions manual.
> >
> >  	  Say N if unsure.
> >
> >
> 
> 
> --
> ~Randy