linux-kernel - Re: [PATCH v2 11/25] net: cadence: switch to using nvmem_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd51c2fb-9f86-450a-74d1-0cba5c9e9cee@microchip.com>
Date:   Sun, 18 Nov 2018 15:42:34 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <brgl@...ev.pl>, <nsekhar@...com>, <khilman@...nel.org>,
        <linux@...linux.org.uk>, <arnd@...db.de>,
        <gregkh@...uxfoundation.org>, <dwmw2@...radead.org>,
        <computersforpeace@...il.com>, <boris.brezillon@...tlin.com>,
        <marek.vasut@...il.com>, <richard@....at>, <davem@...emloft.net>,
        <grygorii.strashko@...com>, <srinivas.kandagatla@...aro.org>,
        <andrew@...n.ch>, <f.fainelli@...il.com>, <robh+dt@...nel.org>,
        <frowand.list@...il.com>, <wsa@...-dreams.de>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-i2c@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <bgolaszewski@...libre.com>
Subject: Re: [PATCH v2 11/25] net: cadence: switch to using
 nvmem_get_mac_address()

On 13/11/2018 at 15:01, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> We now have a generalized helper routine to read the MAC address from
> nvmem which takes struct device as argument. The nvmem subsystem will
> then try device tree first before all other potential providers.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 1d86b4d5645a..d9a208f7bb40 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4055,7 +4055,7 @@ static int macb_probe(struct platform_device *pdev)
>   	if (mac) {
>   		ether_addr_copy(bp->dev->dev_addr, mac);
>   	} else {
> -		err = of_get_nvmem_mac_address(np, bp->dev->dev_addr);
> +		err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr);
>   		if (err) {
>   			if (err == -EPROBE_DEFER)
>   				goto err_out_free_netdev;
> 


-- 
Nicolas Ferre