linux-kernel - Re: [PATCH v1 2/2] i2c: i2c-stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201811181524.WpzzWNmB%fengguang.wu@intel.com>
Date:   Sun, 18 Nov 2018 15:05:43 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Pierre-Yves MORDRET <pierre-yves.mordret@...com>
Cc:     kbuild-all@...org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Pierre-Yves MORDRET <pierre-yves.mordret@...com>,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] i2c: i2c-stm32f7: SYSCFG Fast Mode Plus support
 for I2C STM32F7

Hi Pierre-Yves,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.20-rc2 next-20181116]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pierre-Yves-MORDRET/SYSCFG-Fast-Mode-Plus-support-for-I2C-STM32F7/20181118-135056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: s390-allmodconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=s390 

All errors (new ones prefixed by >>):

   drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_setup_fm_plus_bits':
>> drivers/i2c/busses/i2c-stm32f7.c:1790:9: error: implicit declaration of function 'regmap_update_bits'; did you mean 'set_pgste_bits'? [-Werror=implicit-function-declaration]
     return regmap_update_bits(i2c_dev->regmap, reg, mask, mask);
            ^~~~~~~~~~~~~~~~~~
            set_pgste_bits
   cc1: some warnings being treated as errors

vim +1790 drivers/i2c/busses/i2c-stm32f7.c

  1768	
  1769	static int stm32f7_i2c_setup_fm_plus_bits(struct platform_device *pdev,
  1770						  struct stm32f7_i2c_dev *i2c_dev)
  1771	{
  1772		struct device_node *np = pdev->dev.of_node;
  1773		int ret;
  1774		u32 reg, mask;
  1775	
  1776		i2c_dev->regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg-fmp");
  1777		if (IS_ERR(i2c_dev->regmap)) {
  1778			/* Optional */
  1779			return 0;
  1780		}
  1781	
  1782		ret = of_property_read_u32_index(np, "st,syscfg-fmp", 1, &reg);
  1783		if (ret)
  1784			return ret;
  1785	
  1786		ret = of_property_read_u32_index(np, "st,syscfg-fmp", 2, &mask);
  1787		if (ret)
  1788			return ret;
  1789	
> 1790		return regmap_update_bits(i2c_dev->regmap, reg, mask, mask);
  1791	}
  1792	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (52103 bytes)