linux-kernel - Re: [PATCH] regulator: Fix return value of _set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WTqUjivgD=v7u6fZfPt1vG-Dgv4kw7H3GvhMm7B3-vrA@mail.gmail.com>
Date:   Mon, 19 Nov 2018 09:23:24 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Cheng-Yi Chiang <cychiang@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: Fix return value of _set_load() stub

Hi,

On Fri, Nov 16, 2018 at 7:21 PM Mark Brown <broonie@...nel.org> wrote:
>
> The stub implementation of _set_load() returns a mode value which is
> within the bounds of valid return codes for success (the documentation
> just says that failures are negative error codes) but not sensible or
> what the actual implementation does.  Fix it to just return 0.
>
> Reported-by: Cheng-Yi Chiang <cychiang@...omium.org>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  include/linux/regulator/consumer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I had the same patch in my queue to send up.  Note that the
documentation of the function was changed in commit e39ce48f5362
("regulator: Rename regulator_set_optimum_mode") though that patch
didn't actually change the code in any significant way so presumably
the bug is from even before that.

Reviewed-by: Douglas Anderson <dianders@...omium.org>