linux-kernel - Re: [PATCH v4 2/2] tpm: add support for partial reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c821b1f3-0c6d-bb52-c2af-d5c0fdc5b468@intel.com>
Date:   Mon, 19 Nov 2018 09:43:00 -0800
From:   Tadeusz Struk <tadeusz.struk@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] tpm: add support for partial reads

On 11/19/18 9:28 AM, Jarkko Sakkinen wrote:
> Ah, you are correct.
> 
> You should add a boolean flag instead of introducing a new variable for
> holding amount that has been read because obviously one read operation
> is enough for backwards compatibility.
> 
> The code could read the code to data_pending and then set
> 
>    priv->data_read = false;
> 
> We do not need the original amount for anything.

but we still need to keep track of how much of the response is left unconsumed.

-- 
Tadeusz