linux-kernel - Re: [PATCH] sched: Do not bug in __sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181119142756.057ad784@gandalf.local.home>
Date:   Mon, 19 Nov 2018 14:27:56 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Laurent Dufour <ldufour@...ux.vnet.ibm.com>,
        Andrew Morton <akpm@...l.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] sched: Do not bug in __sched_setscheduler() when pi is
 not used

On Mon, 19 Nov 2018 11:09:50 -0800
Florian Fainelli <f.fainelli@...il.com> wrote:


> > I did the change against v4.2.8 below.  
> 
> Thanks Steven! Here is the local 4.9 backport:

Yours even updates the comment.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 917be221438b..6b3fff6a6437 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4087,8 +4087,8 @@ static int __sched_setscheduler(struct task_struct *p,
>         int queue_flags = DEQUEUE_SAVE | DEQUEUE_MOVE;
>         struct rq *rq;
> 
> -       /* may grab non-irq protected spin_locks */
> -       BUG_ON(in_interrupt());
> +       /* The pi code expects interrupts enabled */
> +       BUG_ON(pi && in_interrupt());
>  recheck:
>         /* double check policy once rq lock held */