linux-kernel - RE: [PATCH 5/8] bsg: refactor bsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR04MB4925E6D8EC8D401B8C947F37FCD80@SN6PR04MB4925.namprd04.prod.outlook.com>
Date:   Mon, 19 Nov 2018 12:29:27 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Benjamin Block <bblock@...ux.ibm.com>,
        Christoph Hellwig <hch@....de>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "ooo@...ctrozaur.com" <ooo@...ctrozaur.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Benjamin Block <bblock@...ux.vnet.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 5/8] bsg: refactor bsg_ioctl



 
> On Sun, Nov 11, 2018 at 02:32:08PM +0100, Christoph Hellwig wrote:
> > Move all actual functionality into helpers, just leaving the dispatch
> > in this function.
> >
> > Signed-off-by: Christoph Hellwig <hch@....de>
> > ---
> >  block/bsg.c | 158 ++++++++++++++++++++++++----------------------------
> >  1 file changed, 72 insertions(+), 86 deletions(-)
> >
> 
> Looks fine to me. Did ran the same small test-tool I ran against Jens'
> patches, nothing broke.
> 
> Reviewed-by: Benjamin Block <bblock@...ux.ibm.com>
> Tested-by: Benjamin Block <bblock@...ux.ibm.com>
Tested-by: Avri Altman <avri.altman@....com>

Tested the scsi pass-through (ufs-bsg) path - nothing is broken.