linux-kernel - Re: [PATCH][i3c-next] i3c: master: fix mask operation by using the correct operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d569740-e5d3-b8a6-79cf-9885039e53de@synopsys.com>
Date:   Mon, 19 Nov 2018 12:41:10 +0000
From:   vitor <vitor.soares@...opsys.com>
To:     Colin King <colin.king@...onical.com>,
        Vitor Soares <vitor.soares@...opsys.com>,
        Boris Brezillon <boris.brezillon@...tlin.com>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][i3c-next] i3c: master: fix mask operation by using the
 correct operator

Hi Coling,


Thanks for your report.

On 16/11/18 18:42, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The masking operation on status is using a bitwise 'or' rather than
> a bitwise 'and' operator, and hence the result is always non-zero
> which is probably not what is intended. Fix this by using the correct
> operator.
>
> Detected by CoverityScan, CID#1475523 ("Wrong operator used")
>
> Fixes: 88acc98a712a ("i3c: master: Add driver for Synopsys DesignWare IP")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/i3c/master/dw-i3c-master.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 0153e6e9de52..b532e2c9cf5c 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1085,7 +1085,7 @@ static irqreturn_t dw_i3c_master_irq_handler(int irq, void *dev_id)
>   
>   	spin_lock(&master->xferqueue.lock);
>   	dw_i3c_master_end_xfer_locked(master, status);
> -	if (status | INTR_TRANSFER_ERR_STAT)
> +	if (status & INTR_TRANSFER_ERR_STAT)
>   		writel(INTR_TRANSFER_ERR_STAT, master->regs + INTR_STATUS);
>   	spin_unlock(&master->xferqueue.lock);
>   
Acked-by: Vitor Soares <vitor.soares@...opsys.com>