linux-kernel - Re: [PATCH] thermal: tsens: qcom: do not create duplicate regmap debugfs entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Nov 2018 20:52:33 +0530
From:   Amit Kucheria <amit.kucheria@...aro.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Eduardo Valentin <edubezval@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH] thermal: tsens: qcom: do not create duplicate regmap
 debugfs entries

On Thu, Nov 15, 2018 at 11:15 PM Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
>
> Regmap would use device name to create debugfs entries. If the device
> has multiple regmaps it is recommended to use name field in regmap_config.
> Fix this by providing name to the regmap configs correctly.
>
> Without this patch we would see below error on DB820c.
>
> qcom-tsens 4a9000.thermal-sensor: Failed to create 4a9000.thermal-sensor
> debugfs directory

Good catch!

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

Acked-by: Amit Kucheria <amit.kucheria@...aro.org>
Tested-by: Amit Kucheria <amit.kucheria@...aro.org>

after a minor fix below...

> ---
>  drivers/thermal/qcom/tsens-common.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index 3be4be2e0465..78652cac7f3d 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -114,6 +114,14 @@ int get_temp_common(struct tsens_device *tmdev, int id, int *temp)
>  }
>
>  static const struct regmap_config tsens_config = {

I suggest renaming this to tsens_tm_config and modifying the
corresponding devm_regmap_init_mmio below.

> +       .name           = "tm",
> +       .reg_bits       = 32,
> +       .val_bits       = 32,
> +       .reg_stride     = 4,
> +};
> +
> +static const struct regmap_config tsens_srot_config = {
> +       .name           = "srot",
>         .reg_bits       = 32,
>         .val_bits       = 32,
>         .reg_stride     = 4,
> @@ -139,8 +147,8 @@ int __init init_common(struct tsens_device *tmdev)
>                 if (IS_ERR(srot_base))
>                         return PTR_ERR(srot_base);
>
> -               tmdev->srot_map = devm_regmap_init_mmio(tmdev->dev,
> -                                                       srot_base, &tsens_config);
> +               tmdev->srot_map = devm_regmap_init_mmio(tmdev->dev, srot_base,
> +                                                       &tsens_srot_config);
>                 if (IS_ERR(tmdev->srot_map))
>                         return PTR_ERR(tmdev->srot_map);
>
> --
> 2.19.1
>