linux-kernel - [PATCH 4.18 074/171] acpi/nfit, x86/mce: Validate a MCEs address before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181119162631.595558208@linuxfoundation.org>
Date:   Mon, 19 Nov 2018 17:27:50 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Robert Elliott <elliott@....com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Borislav Petkov <bp@...e.de>, Arnd Bergmann <arnd@...db.de>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        linux-edac <linux-edac@...r.kernel.org>,
        linux-nvdimm@...ts.01.org, Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Ross Zwisler <zwisler@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tony Luck <tony.luck@...el.com>, x86-ml <x86@...nel.org>,
        Yazen Ghannam <yazen.ghannam@....com>
Subject: [PATCH 4.18 074/171] acpi/nfit, x86/mce: Validate a MCEs address before using it

4.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Vishal Verma <vishal.l.verma@...el.com>

commit e8a308e5f47e545e0d41d0686c00f5f5217c5f61 upstream.

The NFIT machine check handler uses the physical address from the mce
structure, and compares it against information in the ACPI NFIT table
to determine whether that location lies on an NVDIMM. The mce->addr
field however may not always be valid, and this is indicated by the
MCI_STATUS_ADDRV bit in the status field.

Export mce_usable_address() which already performs validation for the
address, and use it in the NFIT handler.

Fixes: 6839a6d96f4e ("nfit: do an ARS scrub on hitting a latent media error")
Reported-by: Robert Elliott <elliott@....com>
Signed-off-by: Vishal Verma <vishal.l.verma@...el.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
CC: Arnd Bergmann <arnd@...db.de>
Cc: Dan Williams <dan.j.williams@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>
CC: elliott@....com
CC: "H. Peter Anvin" <hpa@...or.com>
CC: Ingo Molnar <mingo@...hat.com>
CC: Len Brown <lenb@...nel.org>
CC: linux-acpi@...r.kernel.org
CC: linux-edac <linux-edac@...r.kernel.org>
CC: linux-nvdimm@...ts.01.org
CC: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
CC: "Rafael J. Wysocki" <rjw@...ysocki.net>
CC: Ross Zwisler <zwisler@...nel.org>
CC: stable <stable@...r.kernel.org>
CC: Thomas Gleixner <tglx@...utronix.de>
CC: Tony Luck <tony.luck@...el.com>
CC: x86-ml <x86@...nel.org>
CC: Yazen Ghannam <yazen.ghannam@....com>
Link: http://lkml.kernel.org/r/20181026003729.8420-2-vishal.l.verma@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 arch/x86/include/asm/mce.h       |    1 +
 arch/x86/kernel/cpu/mcheck/mce.c |    3 ++-
 drivers/acpi/nfit/mce.c          |    4 ++++
 3 files changed, 7 insertions(+), 1 deletion(-)

--- a/arch/x86/include/asm/mce.h
+++ b/arch/x86/include/asm/mce.h
@@ -217,6 +217,7 @@ static inline int umc_normaddr_to_sysadd
 int mce_available(struct cpuinfo_x86 *c);
 bool mce_is_memory_error(struct mce *m);
 bool mce_is_correctable(struct mce *m);
+int mce_usable_address(struct mce *m);

 DECLARE_PER_CPU(unsigned, mce_exception_count);
 DECLARE_PER_CPU(unsigned, mce_poll_count);
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -489,7 +489,7 @@ static void mce_report_event(struct pt_r
  * be somewhat complicated (e.g. segment offset would require an instruction
  * parser). So only support physical addresses up to page granuality for now.
  */
-static int mce_usable_address(struct mce *m)
+int mce_usable_address(struct mce *m)
 {
 	if (!(m->status & MCI_STATUS_ADDRV))
 		return 0;
@@ -509,6 +509,7 @@ static int mce_usable_address(struct mce

 	return 1;
 }
+EXPORT_SYMBOL_GPL(mce_usable_address);

 bool mce_is_memory_error(struct mce *m)
 {
--- a/drivers/acpi/nfit/mce.c
+++ b/drivers/acpi/nfit/mce.c
@@ -29,6 +29,10 @@ static int nfit_handle_mce(struct notifi
 	if (!mce_is_memory_error(mce) || mce_is_correctable(mce))
 		return NOTIFY_DONE;

+	/* Verify the address reported in the MCE is valid. */
+	if (!mce_usable_address(mce))
+		return NOTIFY_DONE;
+
 	/*
 	 * mce->addr contains the physical addr accessed that caused the
 	 * machine check. We need to walk through the list of NFITs, and see