linux-kernel - Re: [PATCH -next] exportfs: fix 'passing zero to ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181119044737.GL32577@ZenIV.linux.org.uk>
Date:   Mon, 19 Nov 2018 04:47:37 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     mszeredi@...hat.com, amir73il@...il.com, neilb@...e.com,
        bfields@...hat.com, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, matt.helsley@...il.com
Subject: Re: [PATCH -next] exportfs: fix 'passing zero to ERR_PTR()' warning

On Mon, Nov 19, 2018 at 11:32:41AM +0800, YueHaibing wrote:
> Fix a static code checker warning:
>   fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'
> 
> The error path for lookup_one_len_unlocked failure
> should set err to PTR_ERR.
> 
> Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.