linux-kernel - Re: [PATCH 7/7] regulator: core: Remove loop disabling supplies in regulator_force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UJ4rKV6N9b82dDf5iWFYO9pFKZXAr0Ud4R-C0+CccyoA@mail.gmail.com>
Date:   Tue, 20 Nov 2018 09:55:44 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Evan Green <evgreen@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Dmitry Osipenko <digetx@...il.com>, ryandcase@...omium.org,
        David Collins <collinsd@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] regulator: core: Remove loop disabling supplies in regulator_force_disable()

Hi,

On Mon, Nov 19, 2018 at 4:27 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> In regulator_force_disable() there was a strange loop that looked like:
>
>   while (rdev->open_count--)
>     regulator_disable(rdev->supply);
>
> I'm not totally sure what the goal was for this loop, but it seems
> wrong to me.  If anything I think maybe we should have been looping
> over our use_count, but even that might be a little strange.  For now
> let's just remove the code and we can add something back in if someone
> can explain what's expected.
>
> Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
>  drivers/regulator/core.c | 4 ----
>  1 file changed, 4 deletions(-)

For breadcrumbs: the next version of this patch is now squashed into
("[PATCH v2 2/2] regulator: core: Avoid propagating to supplies when
possible") AKA <http://lkml.kernel.org/r/20181120175255.227783-2-dianders@chromium.org>

-Doug