linux-kernel - Re: [PATCH net-next] net: hns3: add common validation in hclge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181119.183224.87651627805917399.davem@davemloft.net>
Date:   Mon, 19 Nov 2018 18:32:24 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tanxiaojun@...wei.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        lipeng321@...wei.com, linyunsheng@...wei.com,
        shenjian15@...wei.com, tanhuazhong@...wei.com,
        liangfuyun1@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: hns3: add common validation in hclge_dcb

From: Tan Xiaojun <tanxiaojun@...wei.com>
Date: Mon, 19 Nov 2018 21:02:15 +0800

> From: Yunsheng Lin <linyunsheng@...wei.com>
> 
> Before setting tm related configuration to hardware, driver
> needs to check the configuration provided by user is valid.
> Currently hclge_ieee_setets and hclge_setup_tc both implement
> their own checking, which has a lot in common.
> 
> This patch addes hclge_dcb_common_validate to do the common
> checking. The checking in hclge_tm_prio_tc_info_update
> and hclge_tm_schd_info_update is unnecessary now, so change
> the return type to void, which removes the need to do error
> handling when one of the checking fails.
> 
> Also, ets->prio_tc is indexed by user prio and ets->tc_tsa is
> indexed by tc num, so this patch changes them to use different
> index.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Signed-off-by: Tan Xiaojun <tanxiaojun@...wei.com>

Looks good, applied, thanks!