linux-kernel - Re: [PATCH v3] debugobjects: scale the static pool size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3548de1f5204165748c92314fbd24a10e47b8c5.camel@perches.com>
Date:   Tue, 20 Nov 2018 15:58:59 -0800
From:   Joe Perches <joe@...ches.com>
To:     Qian Cai <cai@....us>, Waiman Long <longman@...hat.com>
Cc:     tglx@...utronix.de, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, yang.shi@...ux.alibaba.com,
        arnd@...db.de
Subject: Re: [PATCH v3] debugobjects: scale the static pool size

On Wed, 2018-11-21 at 00:54 +0100, Qian Cai wrote:
> On 11/20/18 at 6:38 PM, Waiman Long wrote:
> > On 11/20/2018 06:28 PM, Qian Cai wrote:
> > > The current value of the early boot static pool size is not big enough
> > > for systems with large number of CPUs with timer or/and workqueue
> > > objects selected. As the results, systems have 60+ CPUs with both timer
> > > and workqueue objects enabled could trigger "ODEBUG: Out of memory.
> > > ODEBUG disabled". Hence, fixed it by computing it according to
> > > CONFIG_NR_CPUS and CONFIG_DEBUG_OBJECTS_* options.
[]
> > > +#define ODEBUG_POOL_SIZE	(ODEBUG_DEFAULT_POOL + CONFIG_NR_CPUS * \
> > > +(ODEBUG_TIMERS_PCPU_CNT + ODEBUG_WORK_PCPU_CNT))
> > 
> > Just a nit about indentation. There should be some indentation in the
> > continued line.
> 
> I am fine to add that, but checkpatch.pl complained
> that there should no spaces at the beginning of a
> newline. Guess we just ignore the warning?
> 
> “please, no spaces at the start of a line”

It wants tabs '0x09' and not spaces '0x20'