linux-kernel - Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Nov 2018 09:40:56 +0000
From:   John Garry <john.garry@...wei.com>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        <james.smart@...adcom.com>, <dick.kennedy@...adcom.com>,
        <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>
CC:     <jrdr.linux@...il.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <brajeswar.linux@...il.com>
Subject: Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

On 18/11/2018 14:38, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> ---
>  drivers/scsi/lpfc/lpfc_sli.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 783a154..3491ff7 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -6229,7 +6229,7 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,
>  			goto free_mem;
>  		}
>
> -		dmabuf->virt = dma_alloc_coherent(&phba->pcidev->dev,
> +		dmabuf->virt = dma_zalloc_coherent(&phba->pcidev->dev,
>  						  LPFC_RAS_MAX_ENTRY_SIZE,

please ensure that you maintain alignment with opening brackets

>  						  &dmabuf->phys,
>  						  GFP_KERNEL);
> @@ -6240,7 +6240,6 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,
>  					"6187 DMA Alloc Failed FW logging");
>  			goto free_mem;
>  		}
> -		memset(dmabuf->virt, 0, LPFC_RAS_MAX_ENTRY_SIZE);
>  		dmabuf->buffer_tag = i;
>  		list_add_tail(&dmabuf->list, &ras_fwlog->fwlog_buff_list);
>  	}
>