linux-kernel - Re: [PATCH] staging: greybus: Parenthesis alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Nov 2018 10:43:58 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Cristian Sicilia <sicilia.cristian@...il.com>
Cc:     Vaibhav Hiremath <hvaibhav.linux@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Vaibhav Agarwal <vaibhav.sr@...il.com>,
        Mark Greer <mgreer@...malcreek.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        David Lin <dtwlin@...il.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Bryan O'Donoghue <pure.logic@...us-software.ie>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: Parenthesis alignment

On Sun, Nov 18, 2018 at 08:28:07PM +0100, Cristian Sicilia wrote:
> Some parameters are aligned with parentheses.
> Some parentheses are opened at end of line.
> 
> Signed-off-by: Cristian Sicilia <sicilia.cristian@...il.com>
> ---
>  drivers/staging/greybus/arche-platform.c       |   6 +-
>  drivers/staging/greybus/audio_codec.c          |   8 +-
>  drivers/staging/greybus/audio_manager_module.c |  55 +++++----
>  drivers/staging/greybus/audio_manager_sysfs.c  |  22 ++--
>  drivers/staging/greybus/audio_module.c         |  34 +++---
>  drivers/staging/greybus/audio_topology.c       |  70 ++++++------
>  drivers/staging/greybus/bootrom.c              |  25 +++--
>  drivers/staging/greybus/camera.c               |  20 ++--
>  drivers/staging/greybus/connection.c           |  82 +++++++-------
>  drivers/staging/greybus/control.c              |  54 ++++-----
>  drivers/staging/greybus/es2.c                  |  71 ++++++------
>  drivers/staging/greybus/gpio.c                 |  40 +++----
>  drivers/staging/greybus/hid.c                  |  26 +++--
>  drivers/staging/greybus/i2c.c                  |  21 ++--
>  drivers/staging/greybus/module.c               |  19 ++--
>  drivers/staging/greybus/operation.c            | 149 +++++++++++++------------
>  drivers/staging/greybus/svc.c                  | 100 ++++++++---------
>  17 files changed, 413 insertions(+), 389 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index 4c36e88..9e2fe3d 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -78,9 +78,9 @@ static void arche_platform_set_state(struct arche_platform_drvdata *arche_pdata,
>  }
>  
>  /* Requires arche_pdata->wake_lock is held by calling context */
> -static void arche_platform_set_wake_detect_state(
> -				struct arche_platform_drvdata *arche_pdata,
> -				enum svc_wakedetect_state state)
> +static void
> +arche_platform_set_wake_detect_state(struct arche_platform_drvdata *arche_pdata,
> +				     enum svc_wakedetect_state state)

Don't change the format "signature" this way please, the whole name and
return type looks better on the same line.

>  {
>  	arche_pdata->wake_detect_state = state;
>  }
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 08746c8..d62f91f 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
>  		i2s_port = 0;	/* fixed for now */
>  		cportid = data->connection->hd_cport_id;
>  		ret = gb_audio_apbridgea_register_cport(data->connection,
> -						i2s_port, cportid,
> +							i2s_port, cportid,
>  						AUDIO_APBRIDGEA_DIRECTION_TX);

This patch doesn't make sense at all, sorry.  Look at how the lines
align now, it's a mix of both styles.  Stick with one or the other, but
never both at the same time.

I would recommend just leaving this all alone, it's good enough as-is.

sorry,

greg k-h