linux-kernel - Re: [PATCH] PCI: histb: constify dw_pcie_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181120113718.GA20893@e107981-ln.cambridge.arm.com>
Date:   Tue, 20 Nov 2018 11:37:18 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     Jianguo Sun <sunjianguo1@...wei.com>,
        kernel-janitors@...r.kernel.org, Shawn Guo <shawn.guo@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: histb: constify dw_pcie_host_ops structure

On Sat, Oct 27, 2018 at 08:31:19PM +0200, Julia Lawall wrote:
> The dw_pcie_host_ops structure is only stored in the ops field
> of a pcie_port structure, and this field is const, so make the
> dw_pcie_host_ops structure const as well.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/pci/controller/dwc/pcie-histb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/dwc for v4.21, thanks.

Lorenzo

> diff -u -p a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
> --- a/drivers/pci/controller/dwc/pcie-histb.c
> +++ b/drivers/pci/controller/dwc/pcie-histb.c
> @@ -202,7 +202,7 @@ static int histb_pcie_host_init(struct p
>  	return 0;
>  }
>  
> -static struct dw_pcie_host_ops histb_pcie_host_ops = {
> +static const struct dw_pcie_host_ops histb_pcie_host_ops = {
>  	.rd_own_conf = histb_pcie_rd_own_conf,
>  	.wr_own_conf = histb_pcie_wr_own_conf,
>  	.host_init = histb_pcie_host_init,
>