linux-kernel - Re: [PATCH] perf/x86: Bump INTEL_PMC_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181120125040.GN2131@hirez.programming.kicks-ass.net>
Date:   Tue, 20 Nov 2018 13:50:40 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, tglx@...utronix.de,
        bp@...en8.de, hpa@...or.com,
        Petri Latvala <petri.latvala@...el.com>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf/x86: Bump INTEL_PMC_MAX_FIXED for Icelake

On Wed, Nov 14, 2018 at 02:25:18PM +0000, Chris Wilson wrote:

> I am not aware of what the consequences are of bumping this limit, so
> please take the patch with a pinch of salt and more of a heads up!

Yeah, this will only make your warning go away, but is not suitable for
upstream. The upstream icelake enablement would be a much larger patch
that actually enables the new PMU features.

So I suggest you carry this in your CI tree until the icelake patches
are allowed to go public.

> diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
> index 8bdf74902293..ab4cf7c12c40 100644
> --- a/arch/x86/include/asm/perf_event.h
> +++ b/arch/x86/include/asm/perf_event.h
> @@ -7,7 +7,7 @@
>   */
>  
>  #define INTEL_PMC_MAX_GENERIC				       32
> -#define INTEL_PMC_MAX_FIXED					3
> +#define INTEL_PMC_MAX_FIXED					4
>  #define INTEL_PMC_IDX_FIXED				       32
>  
>  #define X86_PMC_IDX_MAX					       64
> -- 
> 2.19.1
>