linux-kernel - Re: [PATCH v2] watchdog: cpwd: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <205bee9b-7323-77ce-3f08-fa23ce7bdc9a@roeck-us.net>
Date:   Tue, 20 Nov 2018 07:00:31 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Yangtao Li <tiny.windzz@...il.com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] watchdog: cpwd: add of_node_put()

On 11/20/18 6:54 AM, Yangtao Li wrote:
> use of_node_put() to release the refcount.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Changes in v2:
> -do that right after its last use to also cover
>   error handling.
> ---
>   drivers/watchdog/cpwd.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> index aee0b25cf10d..32156e199c51 100644
> --- a/drivers/watchdog/cpwd.c
> +++ b/drivers/watchdog/cpwd.c
> @@ -570,6 +570,8 @@ static int cpwd_probe(struct platform_device *op)
>   	if (str_prop)
>   		p->timeout = simple_strtoul(str_prop, NULL, 10);
>   
> +	of_node_put(options);
> +
>   	/* CP1400s seem to have broken PLD implementations-- the
>   	 * interrupt_mask register cannot be written, so no timer
>   	 * interrupts can be masked within the PLD.
>