linux-kernel - Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1542726774.28362.13.camel@suse.com>
Date:   Tue, 20 Nov 2018 16:12:54 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        stern@...land.harvard.edu
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3] usb: hub: add retry routine after intr URB submit
 error


> Anytime "in_reset" is set "quiescing" is also set:
> 
> static int hub_pre_reset(struct usb_interface *intf)
> {
> 	struct usb_hub *hub = usb_get_intfdata(intf);
> 
> 	hub_quiesce(hub, HUB_PRE_RESET); //sets quiesce
> 	hub->in_reset = 1;
> 	hub_pm_barrier_for_all_ports(hub);
> 	return 0;
> }
> 
> static int hub_post_reset(struct usb_interface *intf)
> {
> 	struct usb_hub *hub = usb_get_intfdata(intf);
> 
> 	hub->in_reset = 0;
> 	hub_pm_barrier_for_all_ports(hub);
> 	hub_activate(hub, HUB_POST_RESET); //clears quiesce
> 	return 0;
> }
> 
> I should be OK isn't it?

Sorry, yes, I overlooked that there are two flags.

	Regards
		Oliver