linux-kernel - Re: [PATCH] cpuidle: big.LITTLE: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g==G+_HkOnjfecCimxpQgXxeTJ3e-Uyi_YHfq+BE5jRA@mail.gmail.com>
Date:   Tue, 20 Nov 2018 16:23:57 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     tiny.windzz@...il.com
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpuidle: big.LITTLE: add of_node_put()

On Tue, Nov 20, 2018 at 2:00 PM Yangtao Li <tiny.windzz@...il.com> wrote:
>
> use of_node_put() to release the refcount.

I gather that the of_node_put() is missing?

If so, that should be stated in the changelog too.

> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/cpuidle/cpuidle-big_little.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> index db2ede565f1a..a3b8bc09bac8 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -174,8 +174,10 @@ static int __init bl_idle_init(void)
>         /*
>          * Initialize the driver just for a compliant set of machines
>          */
> -       if (!of_match_node(compatible_machine_match, root))
> -               return -ENODEV;
> +       if (!of_match_node(compatible_machine_match, root)){
> +               ret = -ENODEV;
> +               goto out_release_node;
> +       }
>
>         if (!mcpm_is_available())
>                 return -EUNATCH;
> @@ -222,6 +224,8 @@ static int __init bl_idle_init(void)
>         kfree(bl_idle_big_driver.cpumask);
>  out_uninit_little:
>         kfree(bl_idle_little_driver.cpumask);
> +out_release_node:
> +       of_node_put(root);
>
>         return ret;
>  }
> --
> 2.17.0
>