linux-kernel - Re: [PATCH v2] cpuidle: big.LITTLE: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Nov 2018 00:08:58 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     rafael@...nel.org
Cc:     lorenzo.pieralisi@....com,
        Daniel Lezcano <daniel.lezcano@...aro.org>, rjw@...ysocki.net,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpuidle: big.LITTLE: add of_node_put()

On Wed, Nov 21, 2018 at 12:06 AM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Tue, Nov 20, 2018 at 4:46 PM Yangtao Li <tiny.windzz@...il.com> wrote:
> >
> > The of_node_put() is missing.So we call the of_node_put() to release
> > the refcount.
>
> I would say "of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it."
>
> Thanks,
> Rafael
Hi Rafael：

You are right, I will change it right away.

Yours，
    Yangtao