linux-kernel - Re: [PATCH v3 4/7] cgroup: cgroup v2 freezer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181120163604.GX2509588@devbig004.ftw2.facebook.com>
Date:   Tue, 20 Nov 2018 08:36:04 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Roman Gushchin <guro@...com>
Cc:     Roman Gushchin <guroan@...il.com>, Oleg Nesterov <oleg@...hat.com>,
        "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v3 4/7] cgroup: cgroup v2 freezer

On Tue, Nov 20, 2018 at 04:33:11PM +0000, Roman Gushchin wrote:
> > If a non-frozen task is being moved into a frozen cgroup, shouldn't
> > that also trigger frozen state update?
> 
> It does! Just below these lines:
> 
> 	/*
> 	 * If the task isn't in the desired state, force it to it.
> 	 */
> 	if (task->frozen != test_bit(CGRP_FREEZE, &dst->flags))
> 		cgroup_freeze_task(task, test_bit(CGRP_FREEZE, &dst->flags));

But that wouldn't udpate the cgroup's frozen state and generate
notifications, right?

Thanks.

-- 
tejun