linux-kernel - Re: Applied "regulator: core: add enable_count for consumers to debug fs" to the regulator tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Xgp=2vicWuMmp_hQ4LqL+bE91cyuSSRPT8=M2LK=9jsA@mail.gmail.com>
Date:   Tue, 20 Nov 2018 08:44:46 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: Applied "regulator: core: add enable_count for consumers to debug
 fs" to the regulator tree

Hi,

On Tue, Nov 20, 2018 at 8:41 AM Mark Brown <broonie@...nel.org> wrote:
>
> On Tue, Nov 20, 2018 at 08:37:04AM -0800, Doug Anderson wrote:
>
> > Hold up!  How does this compile for you?  It looks as if you landed it
> > before ("regulator: core: Only count load for enabled consumers")
> > which is the patch that adds "enable_count" to the consumer structure.
>
> > I'm just working on my replies to you about the dependencies on these
> > patches but they're definitely not separate...
>
> Dunno, but my script for applying things does a build after each patch
> and didn't complain so...  are you sure it's not e-mails getting
> reordered?

The first thing I did was to fetch linuxregulator/for-next and confirm
that it had this patch but not the patch it depends on.

Now I just tried checking out this git hash:

f556213bad39 ("regulator: core: add enable_count for consumers to debug fs")

When I build I get:

drivers/regulator/core.c: In function 'regulator_summary_show_subtree':
drivers/regulator/core.c:5229:16: error: 'struct regulator' has no
member named 'enable_count'
        consumer->enable_count,
                ^
drivers/regulator/core.c:5231:38: error: 'struct regulator' has no
member named 'enable_count'
        consumer->uA_load && !consumer->enable_count ?
                                      ^

...which is consistent with what I would expect.

-Doug