linux-kernel - Re: [PATCH v2 16/15 v2] syscall_get_arch: add "struct task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181121194549.4glznckje73z2uxk@pburton-laptop>
Date:   Wed, 21 Nov 2018 19:45:51 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     "Dmitry V. Levin" <ldv@...linux.org>
CC:     Andy Lutomirski <luto@...nel.org>, Eric Paris <eparis@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        Elvira Khabirova <lineprinter@...linux.org>,
        Eugene Syromyatnikov <esyr@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        "linux-audit@...hat.com" <linux-audit@...hat.com>,
        "linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-c6x-dev@...ux-c6x.org" <linux-c6x-dev@...ux-c6x.org>,
        "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        "linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>,
        "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>,
        "openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>,
        "sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
        "uclinux-h8-devel@...ts.sourceforge.jp" 
        <uclinux-h8-devel@...ts.sourceforge.jp>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 16/15 v2] syscall_get_arch: add "struct task_struct *"
 argument

Hi Dmitry,

On Wed, Nov 21, 2018 at 10:35:12PM +0300, Dmitry V. Levin wrote:
> This argument is required to extend the generic ptrace API with
> PTRACE_GET_SYSCALL_INFO request: syscall_get_arch() is going to be
> called from ptrace_request() along with other syscall_get_* functions
> with a tracee as their argument.
> 
> This change partially reverts commit 5e937a9ae913 ("syscall_get_arch:
> remove useless function arguments").
> 
> Reviewed-by: Andy Lutomirski <luto@...nel.org> # for x86
> Reviewed-by: Palmer Dabbelt <palmer@...ive.com>
> Cc: linux-audit@...hat.com
> Cc: linux-alpha@...r.kernel.org
> Cc: linux-arch@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-c6x-dev@...ux-c6x.org
> Cc: linux-hexagon@...r.kernel.org
> Cc: linux-ia64@...r.kernel.org
> Cc: linux-m68k@...ts.linux-m68k.org
> Cc: linux-mips@...ux-mips.org
> Cc: linux-parisc@...r.kernel.org
> Cc: linux-riscv@...ts.infradead.org
> Cc: linux-s390@...r.kernel.org
> Cc: linux-sh@...r.kernel.org
> Cc: linux-snps-arc@...ts.infradead.org
> Cc: linux-um@...ts.infradead.org
> Cc: linux-xtensa@...ux-xtensa.org
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: nios2-dev@...ts.rocketboards.org
> Cc: openrisc@...ts.librecores.org
> Cc: sparclinux@...r.kernel.org
> Cc: uclinux-h8-devel@...ts.sourceforge.jp
> Cc: x86@...nel.org
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> ---
> 
> v2: cleaned up mips part, added Reviewed-by

I thought the last one was v2? :)

Anyway, this looks fine to me now:

    Acked-by: Paul Burton <paul.burton@...s.com> # MIPS parts

Thanks,
    Paul