[<prev] [next>] [day] [month] [year] [list]
Message-ID: <201811220330.I6nwAdIH%fengguang.wu@intel.com>
Date: Thu, 22 Nov 2018 03:55:33 +0800
From: kbuild test robot <lkp@...el.com>
To: Jiri Kosina <jkosina@...e.cz>
Cc: kbuild-all@...org, linux-kernel@...r.kernel.org,
tipbuild@...or.com, Thomas Gleixner <tglx@...utronix.de>
Subject: [tip:WIP.x86/pti 26/26] arch/x86//kernel/cpu/bugs.c:343:4: error:
'app2app_mode' undeclared; did you mean 'app2app_options'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/pti
head: 1dbc1eb4f898d3df3b663ce1d938693554877fd6
commit: 1dbc1eb4f898d3df3b663ce1d938693554877fd6 [26/26] x86/speculation: Add 'seccomp' Spectre v2 app to app protection mode
config: i386-randconfig-x002-201846 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 1dbc1eb4f898d3df3b663ce1d938693554877fd6
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
arch/x86//kernel/cpu/bugs.c: In function 'spectre_v2_app2app_select_mitigation':
>> arch/x86//kernel/cpu/bugs.c:343:4: error: 'app2app_mode' undeclared (first use in this function); did you mean 'app2app_options'?
app2app_mode = SPECTRE_V2_APP2APP_SECCOMP;
^~~~~~~~~~~~
app2app_options
arch/x86//kernel/cpu/bugs.c:343:4: note: each undeclared identifier is reported only once for each function it appears in
vim +343 arch/x86//kernel/cpu/bugs.c
317
318 static void __init
319 spectre_v2_app2app_select_mitigation(enum spectre_v2_mitigation_cmd v2_cmd)
320 {
321 enum spectre_v2_app2app_mitigation mode = SPECTRE_V2_APP2APP_NONE;
322 bool smt_possible = IS_ENABLED(CONFIG_SMP);
323
324 if (!boot_cpu_has(X86_FEATURE_IBPB) && !boot_cpu_has(X86_FEATURE_STIBP))
325 return;
326
327 if (cpu_smt_control == CPU_SMT_FORCE_DISABLED ||
328 cpu_smt_control == CPU_SMT_NOT_SUPPORTED)
329 smt_possible = false;
330
331 switch (spectre_v2_parse_app2app_cmdline(v2_cmd)) {
332 case SPECTRE_V2_APP2APP_CMD_NONE:
333 goto set_mode;
334 case SPECTRE_V2_APP2APP_CMD_FORCE:
335 mode = SPECTRE_V2_APP2APP_STRICT;
336 break;
337 case SPECTRE_V2_APP2APP_CMD_PRCTL:
338 mode = SPECTRE_V2_APP2APP_PRCTL;
339 break;
340 case SPECTRE_V2_APP2APP_CMD_AUTO:
341 case SPECTRE_V2_APP2APP_CMD_SECCOMP:
342 if (IS_ENABLED(CONFIG_SECCOMP))
> 343 app2app_mode = SPECTRE_V2_APP2APP_SECCOMP;
344 else
345 app2app_mode = SPECTRE_V2_APP2APP_PRCTL;
346 break;
347 }
348
349 /* Initialize Indirect Branch Prediction Barrier */
350 if (boot_cpu_has(X86_FEATURE_IBPB)) {
351 setup_force_cpu_cap(X86_FEATURE_USE_IBPB);
352
353 switch (mode) {
354 case SPECTRE_V2_APP2APP_STRICT:
355 static_branch_enable(&switch_to_always_ibpb);
356 break;
357 case SPECTRE_V2_APP2APP_PRCTL:
358 case SPECTRE_V2_APP2APP_SECCOMP:
359 static_branch_enable(&switch_to_cond_ibpb);
360 break;
361 default:
362 break;
363 }
364
365 pr_info("mitigation: Enabling %s Indirect Branch Prediction Barrier\n",
366 mode == SPECTRE_V2_APP2APP_STRICT ? "forced" : "conditional");
367 }
368
369 /* If enhanced IBRS is enabled no STIPB required */
370 if (spectre_v2_enabled == SPECTRE_V2_IBRS_ENHANCED)
371 return;
372
373 /*
374 * If STIBP is not available or SMT is not possible clear the STIPB
375 * mode.
376 */
377 if (!smt_possible || !boot_cpu_has(X86_FEATURE_STIBP))
378 mode = SPECTRE_V2_APP2APP_NONE;
379 set_mode:
380 spectre_v2_app2app = mode;
381 /* Only print the STIBP mode when SMT possible */
382 if (smt_possible)
383 pr_info("%s\n", spectre_v2_app2app_strings[mode]);
384 }
385
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (30021 bytes)
Powered by blists - more mailing lists