linux-kernel - Re: [PATCH v2] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Nov 2018 23:23:54 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Girija Kumar Kasinadhuni" <gkumar@...erware.com>
Cc:     <alsa-devel@...a-project.org>, "Hui Wang" <hui.wang@...onical.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Kailang Yang" <kailang@...ltek.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop

On Wed, 21 Nov 2018 18:49:11 +0100,
Girija Kumar Kasinadhuni wrote:
> 
> @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> +	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_AUTO_MUTE),

So this adds a new entry with the very same ID as the previous entry.
This won't work, unfortunately.  The quirk is chosen only for the
first matching one.

For making it working, you'd need to add to the chain of the existing
quirk instead.

And this shows that the patch wasn't properly tested...  Please check
the actual behavior before submitting the final version.


thanks,

Takashi