linux-kernel - RE: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A452FAC4F7CA284ABAC2C8FAB7160B2F3239A4@ORSMSX115.amr.corp.intel.com>
Date:   Wed, 21 Nov 2018 23:48:29 +0000
From:   "Pathan, Arshiya Hayatkhan" <arshiya.hayatkhan.pathan@...el.com>
To:     "Moger, Babu" <Babu.Moger@....com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H Peter Anvin" <hpa@...or.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        James Morse <james.morse@....com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@...el.com>
CC:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from
 perf IMC counter and from resctrl file system

> > +static int initialize_mem_bw_imc(void)
> > +{
> > +	int imc, j;
> > +
> > +	imcs = num_of_imcs();
> > +	if (imcs < 0)
> 
> I think this condition should be "<=". Pls check.

Thank you for pointing it out. It makes sense to change it to "<=". Will fix it in next version.

> > +		return imcs;
> > +
> > +	/* Initialize perf_event_attr structures for all iMC's */
> > +	for (imc = 0; imc < imcs; imc++) {
> > +		for (j = 0; j < 2; j++)
> > +			membw_initialize_perf_event_attr(imc, j);
> > +	}
> > +
> > +	return 0;
> > +}

Thanks and Regards,
Arshiya