linux-kernel - Re: [PATCH v2] tee: optee: log message if dynamic shm is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181121073648.GA20049@jax.urgonet>
Date:   Wed, 21 Nov 2018 08:36:49 +0100
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Victor Chong <victor.chong@...aro.org>
Cc:     tee-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] tee: optee: log message if dynamic shm is enabled

Hi Victor,

On Tue, Sep 11, 2018 at 06:09:02PM +0900, Victor Chong wrote:
> When dynamic shared memory support is enabled in the OP-TEE Trusted
> OS, it doesn't mean that the driver supports it, which can confuse
> users during debugging. Log a message when dynamic shared memory is
> enabled in the driver, to let users know for sure.
> 
> Suggested-by: Jerome Forissier <jerome.forissier@...aro.org>
> Signed-off-by: Victor Chong <victor.chong@...aro.org>
> Reviewed-by: Jerome Forissier <jerome.forissier@...aro.org>
> ---
> 
> v2:
> * Added patch description
> 
> [v1] lore.kernel.org/patchwork/patch/983949/
> 
>  drivers/tee/optee/core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index e1aafe842d66..cca5c091e55a 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
> 
>         optee_enable_shm_cache(optee);
> 
> +       if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
> +               pr_info("dynamic shared memory is enabled\n");
> +
>         pr_info("initialized driver\n");
>         return optee;
>  err:
> --
> 2.17.1

Looks good. I'm picking this up.

Thanks,
Jens