linux-kernel - Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5229ccbb-e6de-e114-52fb-235ea703a7ef@huawei.com>
Date:   Wed, 21 Nov 2018 07:56:24 +0000
From:   John Garry <john.garry@...wei.com>
To:     James Smart <james.smart@...adcom.com>,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        <dick.kennedy@...adcom.com>, <jejb@...ux.vnet.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <jrdr.linux@...il.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <brajeswar.linux@...il.com>
Subject: Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

On 20/11/2018 21:52, James Smart wrote:
> On 11/20/2018 1:40 AM, John Garry wrote:
>>
>> please ensure that you maintain alignment with opening brackets
>
> I don't think this is a requirement.  From the rules I've read
> preference is tabs-only indentation.

This is the only rule (enforcement) I see:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20181120&id=d1fe9c099cecc6e49324355f1b15573e9dbbe0f9

Spacing (less than a tab), after
> tabs, for open brace alignment is allowed, thus is coder's choice.

It seems that alignment was being implemented with tab+space, and now it 
would be tab+space but no alignment.

cheers,
John

>
> -- james
>
>
>
>
>
>
>