linux-kernel - Re: [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0OqD=mxJmc2hPTp2s1-i1MPZWsjDF37hjSDKrFpzGxWg@mail.gmail.com>
Date:   Wed, 21 Nov 2018 09:55:18 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Olof Johansson <olof@...om.net>, Rob Herring <robh+dt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Andreas Färber <afaerber@...e.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>, linux-serial@...r.kernel.org,
        Amit Kucheria <amit.kucheria@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>, zhao_steven@....net,
        overseas.sales@...soc.com
Subject: Re: [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board

On Wed, Nov 21, 2018 at 4:38 AM Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:
> +       aliases {
> +               serial0 = &uart0;
> +               serial1 = &uart1;
> +               serial2 = &uart2;
> +       };
>
+
> +&uart2 {
> +       status = "okay";
> +       clocks = <&uart2_clk>;
> +};

This is clearly mismatched here: you mark only one uart as 'enabled, but
list three of them as aliases. Having 'serial0' point to a disabled uart
may easily break applications that expect the first one to be the
console.

Best make that

       serial0 = &uart2;

and drop the other ones if only one of them is exposed on the
board. If all three are usable, you should enable them all here,
and make sure that the numbering of the aliases matches the
labels on the board or its documentation.

        Arnd