linux-kernel - Re: [PATCH 4/4] perf intel-pt/bts: fix potential NULL pointer dereference in intel_bts_process_auxtrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60a8972e-037f-8d6b-ce45-76b65a841156@intel.com>
Date:   Wed, 21 Nov 2018 11:13:24 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Wen Yang <wen.yang99@....com.cn>, peterz@...radead.org
Cc:     mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, ak@...ux.intel.com,
        linux-kernel@...r.kernel.org, zhong.weidong@....com.cn,
        wang.yi59@....com.cn, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 4/4] perf intel-pt/bts: fix potential NULL pointer
 dereference in intel_bts_process_auxtrace_info

On 21/11/18 9:43 AM, Wen Yang wrote:
> This patch fixes a possible null pointer dereference in
> intel_bts_process_auxtrace_info, detected by the semantic patch
> deref_null.cocci, with the following warning:
> 
> ./tools/perf/util/intel-bts.c:921:32-49: ERROR: session -> itrace_synth_opts is NULL but dereferenced.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Reviewed-by: Tan Hu <tan.hu@....com.cn>
> CC: Julia Lawall <julia.lawall@...6.fr>
> ---
>  tools/perf/util/intel-bts.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
> index 7b27d77..b0258f4 100644
> --- a/tools/perf/util/intel-bts.c
> +++ b/tools/perf/util/intel-bts.c
> @@ -917,7 +917,8 @@ int intel_bts_process_auxtrace_info(union perf_event *event,
>  	if (session->itrace_synth_opts && session->itrace_synth_opts->set) {
>  		bts->synth_opts = *session->itrace_synth_opts;
>  	} else {
> -		itrace_synth_opts__set_default(&bts->synth_opts,
> +		if (session->itrace_synth_opts)
> +			itrace_synth_opts__set_default(&bts->synth_opts,
>  				session->itrace_synth_opts->default_no_sample);
>  		if (session->itrace_synth_opts)
>  			bts->synth_opts.thread_stack =
> 

See response to patch 1.