linux-kernel - Re: [PATCH] regulator: wm8994: Don't use devres for enable GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9aebaa5-93d0-6b3d-c3b2-f7ef1dbbc4de@samsung.com>
Date:   Wed, 21 Nov 2018 13:24:04 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Charles Keepax <ckeepax@...nsource.cirrus.com>,
        linus.walleij@...aro.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] regulator: wm8994: Don't use devres for enable GPIOs

Hi Mark,

On 2018-11-21 13:19, Mark Brown wrote:
> On Wed, Nov 21, 2018 at 10:26:30AM +0100, Marek Szyprowski wrote:
>
>> from wm8994_ldo_remove(), switched to regulator_register() in
>> wm8994_ldo_probe() and added regulator_unregister() in
>> wm8994_ldo_remove(). This way the warning is gone. If there is any
> I don't understand why you'd need to switch to regulator_register()?

I mixed a few things. This was just a first version of my experiments,
which worked without the warning. In the final solution it was not
needed, see https://lkml.org/lkml/2018/11/21/542

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland