linux-kernel - Re: [PATCH] can: flexcan: Implement CAN Runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24a43a20-7302-c449-06b3-5ee8f6c051a0@pengutronix.de>
Date:   Wed, 21 Nov 2018 15:36:19 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Cc:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "A.s. Dong" <aisheng.dong@....com>
Subject: Re: [PATCH] can: flexcan: Implement CAN Runtime PM

On 10/19/18 11:45 AM, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.dong@....com>
> 
> Flexcan will be disabled during suspend if no wakeup function required
> and enabled after resume accordingly. During this period, we could
> explicitly disable clocks.
> 
> Implement Runtime PM which will:
> 1) Keep device in suspend state (clocks disabled) if it's not openned
> 2) Make Power Domain framework be able to shutdown the corresponding power
> domain of this device.

Without CONFIG_PM the device fails to probe:

> [  214.420606] flexcan 2090000.flexcan: 2090000.flexcan supply xceiver not found, using dummy regulator
> [  214.445952] flexcan 2090000.flexcan: Linked as a consumer to regulator.0
> [  214.453448] flexcan 2090000.flexcan: registering netdev failed
> [  214.459666] flexcan 2090000.flexcan: Dropping the link to regulator.0
> [  214.472066] flexcan: probe of 2090000.flexcan failed with error -110

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)