[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e45f832b-ef98-e419-6082-27dd7ced71d2@cogentembedded.com>
Date: Wed, 21 Nov 2018 18:24:43 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Yangtao Li <tiny.windzz@...il.com>, b.zolnierkie@...sung.com,
axboe@...nel.dk
Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_macio: add of_node_put()
Hello!
On 11/21/2018 04:04 PM, Yangtao Li wrote:
> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.
I thought we're inside pata_macio_cable_detect()?
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
> drivers/ata/pata_macio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index 9588e685d994..8cc9c429ad95 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap)
> struct device_node *root = of_find_node_by_path("/");
> const char *model = of_get_property(root, "model", NULL);
>
> + of_node_put(root);
> +
> if (cable && !strncmp(cable, "80-", 3)) {
> /* Some drives fail to detect 80c cable in PowerBook
> * These machine use proprietary short IDE cable
MBR, Sergei
Powered by blists - more mailing lists