linux-kernel - Re: [PATCH v3] iommu/dma: Use NUMA aware memory allocations in __iommu_dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181121160718.GB24883@arm.com>
Date:   Wed, 21 Nov 2018 16:07:18 +0000
From:   Will Deacon <will.deacon@....com>
To:     John Garry <john.garry@...wei.com>
Cc:     joro@...tes.org, robin.murphy@....com,
        linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
        ganapatrao.kulkarni@...ium.com, hch@....de,
        m.szyprowski@...sung.com, linuxarm@...wei.com
Subject: Re: [PATCH v3] iommu/dma: Use NUMA aware memory allocations in
 __iommu_dma_alloc_pages()

On Wed, Nov 21, 2018 at 10:54:10PM +0800, John Garry wrote:
> From: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
> 
> Change function __iommu_dma_alloc_pages() to allocate pages for DMA from
> respective device NUMA node. The ternary operator which would be for
> alloc_pages_node() is tidied along with this.
> 
> We also include a change to use kvzalloc() for kzalloc()/vzalloc()
> combination.
> 
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
> [JPG: Added kvzalloc(), drop pages ** being device local, tidied ternary operator]
> Signed-off-by: John Garry <john.garry@...wei.com>

Weird, you're missing a diffstat here.

Anyway, the patch looks fine to me, but it would be nice if you could
justify the change with some numbers. Do you actually see an improvement
from this change?

Will