linux-kernel - Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Nov 2018 18:41:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sam Protsenko <semen.protsenko@...aro.org>,
        Christoph Hellwig <hch@....de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        kernel-janitors@...r.kernel.org, jaharkes@...cmu.edu,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        codalist@...a.cs.cmu.edu, coda@...cmu.edu,
        Praneeth Bajjuri <praneeth@...com>,
        Ruslan Bilovol <ruslan.bilovol@...il.com>
Subject: Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

On Wed, Nov 21, 2018 at 6:31 PM Sam Protsenko
<semen.protsenko@...aro.org> wrote:
>
> On Tue, Oct 30, 2018 at 10:27 PM Sam Protsenko
> <semen.protsenko@...aro.org> wrote:
> >
> > The kernel is self-contained project and can be built with bare-metal
> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of
> > this u_quad_t type is not defined when using bare-metal toolchain and
> > codafs build fails. This patch fixes it by defining u_quad_t type
> > unconditionally.
> >
> > Cc: Jan Harkes <jaharkes@...cmu.edu>
> > Cc: Christoph Hellwig <hch@...radead.org>
> > Cc: Andy Shevchenko <andy.shevchenko@...il.com>

I'm not sure how you managed to miss people in this list (perhaps by
default you have suppress all Cc in your Git configuration), but I
guess we may gently ask Christoph to apply this in case Jan will not
appear.

> > Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> > ---
> >  include/linux/coda.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/linux/coda.h b/include/linux/coda.h
> > index d30209b9cef8..0ca0c83fdb1c 100644
> > --- a/include/linux/coda.h
> > +++ b/include/linux/coda.h
> > @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance.
> >  #ifndef _CODA_HEADER_
> >  #define _CODA_HEADER_
> >
> > -#if defined(__linux__)
> >  typedef unsigned long long u_quad_t;
> > -#endif
> > +
> >  #include <uapi/linux/coda.h>
> >  #endif
> > --
> > 2.19.1
> >
>
> + Jan Harkes, + Ruslan Bilovol
>
> Hi Jan,
>
> Can you please apply this? Nobody seems to be interested in taking
> this patch, so I'm not sure how to proceed further. Please advice.
>
> Thanks!



-- 
With Best Regards,
Andy Shevchenko