linux-kernel - Re: [PATCH v5 08/12] dt-bindings: mediatek: Change the binding for mmsys clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154281878765.88331.10581984256202566195@swboyd.mtv.corp.google.com>
Date:   Wed, 21 Nov 2018 08:46:27 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh@...nel.org>
Cc:     matthias.bgg@...nel.org, Mark Rutland <mark.rutland@....com>,
        CK Hu <ck.hu@...iatek.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Ulrich Hecht <ulrich.hecht+renesas@...il.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Sean Wang <sean.wang@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Chen-Yu Tsai <wens@...e.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-mediatek@...ts.infradead.org,
        linux-clk <linux-clk@...r.kernel.org>,
        devicetree@...r.kernel.org, Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v5 08/12] dt-bindings: mediatek: Change the binding for mmsys
 clocks

Quoting Rob Herring (2018-11-19 11:15:16)
> On Sun, Nov 18, 2018 at 11:12 AM Matthias Brugger
> <matthias.bgg@...il.com> wrote:
> > On 11/17/18 12:15 AM, Rob Herring wrote:
> > > On Fri, Nov 16, 2018 at 01:54:45PM +0100, matthias.bgg@...nel.org wrote:
> > >> -    #clock-cells = <1>;
> > >> +
> > >> +    mmsys_clk: clock-controller@...00000 {
> > >> +            compatible = "mediatek,mt2712-mmsys-clk";
> > >> +            #clock-cells = <1>;
> > >
> > > This goes against the general direction of not defining separate nodes
> > > for providers with no resources.
> > >
> > > Why do you need this and what does it buy if you have to continue to
> > > support the existing chips?
> > >
> >
> > It would show explicitly that the mmsys block is used to probe two
> > drivers, one for the gpu and one for the clocks. Otherwise that is
> > hidden in the drm driver code. I think it is cleaner to describe that in
> > the device tree.
> 
> No, that's maybe cleaner for the driver implementation in the Linux
> kernel. What about other OS's or when Linux drivers and subsystems
> needs change? Cleaner for DT is design bindings that reflect the h/w.
> Hardware is sometimes just messy.
> 

I agree. I fail to see what this patch series is doing besides changing
driver probe and device creation methods and making a backwards
incompatible change to DT. Is there any other benefit here?