linux-kernel - Re: [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hlg5mbch9.wl-tiwai@suse.de>
Date:   Wed, 21 Nov 2018 17:51:30 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Girija Kumar Kasinadhuni" <gkumar@...erware.com>
Cc:     <alsa-devel@...a-project.org>, "Hui Wang" <hui.wang@...onical.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "KailangYang" <kailang@...ltek.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop

On Wed, 21 Nov 2018 15:11:31 +0100,
Girija Kumar Kasinadhuni wrote:
> 
> This device makes a loud buzzing sound when a headphone is inserted while
> playing audio at full volume through the speaker.
> 
> Signed-off-by: Girija Kumar Kasinadhuni <gkumar@...erware.com>

The fixup entry you added won't "disable" but it switch to the
auto-mute via amp instead of toggling pin control.
Please correct the subject and the description, and resubmit.


thanks,

Takashi



> ---
>  sound/pci/hda/patch_realtek.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index fa61674..eeff2ff 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5495,6 +5495,7 @@ enum {
>  	ALC255_FIXUP_DELL_HEADSET_MIC,
>  	ALC295_FIXUP_HP_X360,
>  	ALC221_FIXUP_HP_HEADSET_MIC,
> +	ALC295_FIXUP_HP_DISABLE_AUTOMUTE,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -6362,6 +6363,10 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC269_FIXUP_HEADSET_MIC
>  	},
> +	[ALC295_FIXUP_HP_DISABLE_AUTOMUTE] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc_fixup_auto_mute_via_amp,
> +	},
>  };
>  
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> +	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_DISABLE_AUTOMUTE),
>  	SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
>  	SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
>  	SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> -- 
> 2.7.4
>