linux-kernel - [PATCH] usb: misc: fix boolconv.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Nov 2018 18:33:51 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Anatolij Gustschin <agust@...x.de>
cc:     linux-usb@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, broonie@...nel.org, atull@...nel.org,
        mdf@...nel.org, kbuild-all@...org
Subject: [PATCH] usb: misc: fix boolconv.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>

drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices")
CC: Anatolij Gustschin <agust@...x.de>
Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
Signd-off-by: Julia Lawall <julia.lawall@...6.fr>

---

url:    https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181120-161201
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ft232h-intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/misc/ft232h-intf.c
+++ b/drivers/usb/misc/ft232h-intf.c
@@ -813,7 +813,7 @@ static int ftdi_mpsse_gpio_get(struct gp

 	dev_dbg(chip->parent, "%s: offset %d\n", __func__, offset);

-	low = offset < 5 ? true : false;
+	low = offset < 5;

 	mutex_lock(&priv->ops_mutex);