linux-kernel - Re: [PATCH] arc: [devboards] Add support of NFSv3 ACL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <C2D7FE5348E1B147BCA15975FBA2307501464156CB@US01WEMBX2.internal.synopsys.com>
Date:   Wed, 21 Nov 2018 17:40:17 +0000
From:   Vineet Gupta <vineet.gupta1@...opsys.com>
To:     Alexey Brodkin <alexey.brodkin@...opsys.com>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Cupertino Miranda" <cupertino.miranda@...opsys.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] arc: [devboards] Add support of NFSv3 ACL

On 11/20/18 2:30 AM, Alexey Brodkin wrote:
> By default NFSv3 doesn't support ACL (Access Control Lists)
> which might be quite convenient to have so that
> mounted NFS behaves exactly as any other local file-system.
>
> In particular missing support of ACL makes umask useless.
> This among other thigs fixes Glibc's "nptl/tst-umask1".
>
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
> Cc: Cupertino Miranda <cmiranda@...opsys.com>
> Cc: stable@...r.kernel.org

What is this fixing in the kernel, for this to be stable backported  ?

> ---
>  arch/arc/configs/axs101_defconfig          | 1 +
>  arch/arc/configs/axs103_defconfig          | 1 +
>  arch/arc/configs/axs103_smp_defconfig      | 1 +
>  arch/arc/configs/hsdk_defconfig            | 1 +
>  arch/arc/configs/nps_defconfig             | 1 +
>  arch/arc/configs/nsimosci_defconfig        | 1 +
>  arch/arc/configs/nsimosci_hs_defconfig     | 1 +
>  arch/arc/configs/nsimosci_hs_smp_defconfig | 1 +
>  arch/arc/configs/vdk_hs38_defconfig        | 1 +
>  arch/arc/configs/vdk_hs38_smp_defconfig    | 1 +

I understand a sweeping change is easy, more consistent so a good guiding
principel in general. But really all these defconfigs need NFS ? We keep on
increasing the bloat with this. IMHO we should update only relevant defconfigs.

>  10 files changed, 10 insertions(+)
>
> diff --git a/arch/arc/configs/axs101_defconfig b/arch/arc/configs/axs101_defconfig
> index 41bc08be6a3b..8c23bd086cd0 100644
> --- a/arch/arc/configs/axs101_defconfig
> +++ b/arch/arc/configs/axs101_defconfig
> @@ -95,6 +95,7 @@ CONFIG_VFAT_FS=y
>  CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/axs103_defconfig b/arch/arc/configs/axs103_defconfig
> index 1e1c4a8011b5..666314fffc60 100644
> --- a/arch/arc/configs/axs103_defconfig
> +++ b/arch/arc/configs/axs103_defconfig
> @@ -94,6 +94,7 @@ CONFIG_VFAT_FS=y
>  CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
> index 6b0c0cfd5c30..429832b8560b 100644
> --- a/arch/arc/configs/axs103_smp_defconfig
> +++ b/arch/arc/configs/axs103_smp_defconfig
> @@ -97,6 +97,7 @@ CONFIG_VFAT_FS=y
>  CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 1dec2b4bc5e6..2a1d2cbfee1a 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -65,6 +65,7 @@ CONFIG_EXT3_FS=y
>  CONFIG_VFAT_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/nps_defconfig b/arch/arc/configs/nps_defconfig
> index 31ba224bbfb4..ae7a0d8be98d 100644
> --- a/arch/arc/configs/nps_defconfig
> +++ b/arch/arc/configs/nps_defconfig
> @@ -73,6 +73,7 @@ CONFIG_PROC_KCORE=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_DEBUG_INFO=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/nsimosci_defconfig b/arch/arc/configs/nsimosci_defconfig
> index f14eeff7d308..ad77f20e5aa6 100644
> --- a/arch/arc/configs/nsimosci_defconfig
> +++ b/arch/arc/configs/nsimosci_defconfig
> @@ -66,5 +66,6 @@ CONFIG_EXT2_FS_XATTR=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  # CONFIG_ENABLE_MUST_CHECK is not set
> diff --git a/arch/arc/configs/nsimosci_hs_defconfig b/arch/arc/configs/nsimosci_hs_defconfig
> index 025298a48305..1638e5bc9672 100644
> --- a/arch/arc/configs/nsimosci_hs_defconfig
> +++ b/arch/arc/configs/nsimosci_hs_defconfig
> @@ -65,5 +65,6 @@ CONFIG_EXT2_FS_XATTR=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  # CONFIG_ENABLE_MUST_CHECK is not set
> diff --git a/arch/arc/configs/nsimosci_hs_smp_defconfig b/arch/arc/configs/nsimosci_hs_smp_defconfig
> index df7b77b13b82..11cfbdb0f441 100644
> --- a/arch/arc/configs/nsimosci_hs_smp_defconfig
> +++ b/arch/arc/configs/nsimosci_hs_smp_defconfig
> @@ -76,6 +76,7 @@ CONFIG_EXT2_FS_XATTR=y
>  CONFIG_TMPFS=y
>  # CONFIG_MISC_FILESYSTEMS is not set
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
>  # CONFIG_ENABLE_MUST_CHECK is not set
>  CONFIG_FTRACE=y
> diff --git a/arch/arc/configs/vdk_hs38_defconfig b/arch/arc/configs/vdk_hs38_defconfig
> index db47c3541f15..1e59a2e9c602 100644
> --- a/arch/arc/configs/vdk_hs38_defconfig
> +++ b/arch/arc/configs/vdk_hs38_defconfig
> @@ -85,6 +85,7 @@ CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_JFFS2_FS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set
> diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/vdk_hs38_smp_defconfig
> index a8ac5e917d9a..b5c3f6c54b03 100644
> --- a/arch/arc/configs/vdk_hs38_smp_defconfig
> +++ b/arch/arc/configs/vdk_hs38_smp_defconfig
> @@ -90,6 +90,7 @@ CONFIG_NTFS_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_JFFS2_FS=y
>  CONFIG_NFS_FS=y
> +CONFIG_NFS_V3_ACL=y
>  CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_NLS_ISO8859_1=y
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set