linux-kernel - Re: [PATCH v2 2/2] modpost: skip ELF local symbols by default during section mismatch check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1811210950100.18372@viisi.sifive.com>
Date:   Wed, 21 Nov 2018 09:52:52 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     paul.walmsley@...ive.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Russell King <linux@...linux.org.uk>, jimw@...ive.com,
        Michal Marek <michal.lkml@...kovi.net>,
        Sam Ravnborg <sam@...nborg.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Paul Walmsley <paul@...an.com>
Subject: Re: [PATCH v2 2/2] modpost: skip ELF local symbols by default during
 section mismatch check

Hello Masahiro,

On Wed, 21 Nov 2018, Masahiro Yamada wrote:

> I think this is almost good.
> Just a nit.
>
> Maybe, putting this check in secref_whitelist()
> (with a comment "Pattern 6:")
> could look more consistency.
>
>
> Also, if you use strstart() helper,
> you can remove is_local_symbol() function.
>
>
>        /* Check for pattern 6 */
>        if (strstarts(fromsym, ".L"))
>                return 0;
>

Thank you for your suggestion.  This change is a definite improvement. 
The patch has been updated, and I will repost the patch after it's been 
tested.

Best regards,

- Paul