linux-kernel - Re: [PATCH net-next 0/8] net: hns3: Adds support of debugfs to HNS3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Nov 2018 10:25:29 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Salil Mehta <salil.mehta@...wei.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "lipeng (Y)" <lipeng321@...wei.com>,
        "mehta.salil@...src.net" <mehta.salil@...src.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH net-next 0/8] net: hns3: Adds support of debugfs to HNS3
 driver

On Wed, 21 Nov 2018 18:06:19 +0000, Salil Mehta wrote:
> > From: Jakub Kicinski [mailto:jakub.kicinski@...ronome.com]
> > Sent: Monday, November 19, 2018 10:30 PM
> > To: Salil Mehta <salil.mehta@...wei.com>
> > Cc: davem@...emloft.net; Zhuangyuzeng (Yisen) <yisen.zhuang@...wei.com>;
> > lipeng (Y) <lipeng321@...wei.com>; mehta.salil@...src.net;
> > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Linuxarm
> > <linuxarm@...wei.com>
> > Subject: Re: [PATCH net-next 0/8] net: hns3: Adds support of debugfs to
> > HNS3 driver
> > 
> > On Mon, 19 Nov 2018 21:18:37 +0000, Salil Mehta wrote:  
> > > This patchset adds support of debugfs to the HNS3 driver.
> > >
> > > Support has been added to query info related to below items:
> > > 1. Queue related
> > > 2. Flow Director
> > > 3. TC config
> > > 4. Transmit Module/Scheduler
> > > 5. QoS pause
> > > 6. QoS buffer
> > > 7. QoS prio map  
> > 
> > Please provide a more informative cover letter.
> > 
> > From a short glance it looks like you add a single debugfs file, which
> > can be written to, and upon that write the driver will dump stuff into
> > kernel logs.  
> 
> That is correct. Do you foresee any problem with it or are we doing something
> which is objectionable?

Its fine with me, but I think not everyone reading the list will read
the code so a few extra words and adding one of the examples from the
patches to the cover letter could help people understand the changes.