linux-kernel - Re: [PATCH] soc: bcm: brcmstb: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395243f-2c08-6079-e8a8-79712179fe57@gmail.com>
Date:   Wed, 21 Nov 2018 11:23:42 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Yangtao Li <tiny.windzz@...il.com>, computersforpeace@...il.com,
        gregory.0xf0@...il.com, bcm-kernel-feedback-list@...adcom.com,
        olof@...om.net, treding@...dia.com, arnd@...db.de
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: bcm: brcmstb: add of_node_put()



On 11/21/2018 4:43 AM, Yangtao Li wrote:
> of_find_node_by_path() acquires a reference to the node returned
> by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.

You probably copied/pasted this from a prior patch, the function name is
soc_is_brcmstb() here, do you mind fixing that and also providing a
Fixes: tag?

Thanks

> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/soc/bcm/brcmstb/common.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/bcm/brcmstb/common.c b/drivers/soc/bcm/brcmstb/common.c
> index 14185451901d..95b777fffee6 100644
> --- a/drivers/soc/bcm/brcmstb/common.c
> +++ b/drivers/soc/bcm/brcmstb/common.c
> @@ -32,12 +32,15 @@ static const struct of_device_id brcmstb_machine_match[] = {
>  bool soc_is_brcmstb(void)
>  {
>  	struct device_node *root;
> +	bool rc;
>  
>  	root = of_find_node_by_path("/");
>  	if (!root)
>  		return false;
>  
> -	return of_match_node(brcmstb_machine_match, root) != NULL;
> +	rc = of_match_node(brcmstb_machine_match, root) != NULL;
> +	of_node_put(root);
> +	return rc;
>  }
>  
>  u32 brcmstb_get_family_id(void)
> 

-- 
Florian