linux-kernel - Re: [PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h5zwoah63.wl-tiwai@suse.de>
Date:   Thu, 22 Nov 2018 23:20:04 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Borislav Petkov" <bp@...en8.de>
Cc:     "Vasily Khoruzhick" <anarsoul@...il.com>,
        "Linux-ALSA" <alsa-devel@...a-project.org>,
        "Arnd Bergmann" <arnd@...db.de>,
        "Maxime Ripard" <maxime.ripard@...tlin.com>,
        "Chen-Yu Tsai" <wens@...e.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "arm-linux" <linux-arm-kernel@...ts.infradead.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR_REGMAP

On Thu, 22 Nov 2018 22:29:05 +0100,
Borislav Petkov wrote:
> 
> On Fri, Nov 02, 2018 at 03:06:59PM -0700, Vasily Khoruzhick wrote:
> > On Fri, Nov 2, 2018 at 3:04 PM Arnd Bergmann <arnd@...db.de> wrote:
> > >
> > > On 11/2/18, Vasily Khoruzhick <anarsoul@...il.com> wrote:
> > > > On Friday, November 2, 2018 8:33:40 AM PDT Arnd Bergmann wrote:
> > > >> The newly added SND_SUN50I_CODEC_ANALOG driver selects a nonexisting
> > > >> symbol SND_SUNXI_ADDA_PR_REGMAP, which was evidently intended to replace
> > > >> SND_SUN8I_ADDA_PR_REGMAP, but since they are now mismatched, we can run
> > > >> into link errors for some configurations:
> > > >>
> > > >> sound/soc/sunxi/sun50i-codec-analog.o: In function
> > > >> `sun50i_codec_analog_probe': sun50i-codec-analog.c:(.text+0x62):
> > > >> undefined
> > > >> reference to `sun8i_adda_pr_regmap_init'
> > > >>
> > > >> The new name appears to be more sensible, and as the symbol is hidden,
> > > >> there are no downsides in the rename, so use that consistently now.
> > > >
> > > > Maxime asked it to be SND_SUN8I_ADDA_PR_REGMAP, and also it would be easier
> > > > to
> > > > fix it my renaming last remaining SND_SUNXI_ADDA_PR_REGMAP to
> > > > SND_SUN8I_ADDA_PR_REGMAP.
> > >
> > > Sure, I don't care either way. Please send a patch to do that then.
> > 
> > Will do tonight.
> 
> Is that patch coming up or on its way somewhere?
> 
> I still hit randconfig build failures:
> 
> ERROR: "sun8i_adda_pr_regmap_init" [sound/soc/sunxi/sun50i-codec-analog.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2

It's been in Mark's asoc tree.

Mark, could you send a pull request?  It might be too late for rc4,
but sooner, better.


thanks,

Takashi